fix: rewrite results capture keys during counted device expansion#6
Merged
fix: rewrite results capture keys during counted device expansion#6
Conversation
Frando
force-pushed
the
test/diag-fixup-proc-net
branch
from
d5d48ed to
4cef12a
Compare
Frando
changed the title
When a step template has results like `down_bytes = ".size"`, this gets expanded to `"fetcher.size"` during template merge. But for counted devices (fetcher-0, fetcher-1, ...), the capture is stored under `"fetcher-0.size"` while the results key remained `"fetcher.size"`. Fix by also rewriting StepResults capture keys during counted expansion, so `"fetcher.size"` becomes `"fetcher-0.size"` for the expanded step. This fixes missing results in combined-results for multi-device sims (1to3, 1to5, 1to10, 2to2, etc). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Frando
force-pushed
the
test/diag-fixup-proc-net
branch
from
4cef12a to
cbe0a0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a step template has results like
down_bytes = ".size", this getsexpanded to
"fetcher.size"during template merge. But for counteddevices (fetcher-0, fetcher-1, ...), the capture is stored under
"fetcher-0.size"while the results key remained"fetcher.size".Fix by also rewriting StepResults capture keys during counted expansion,
so
"fetcher.size"becomes"fetcher-0.size"for the expanded step.This fixes missing results in combined-results for multi-device sims
(1to3, 1to5, 1to10, 2to2, etc).